Require keyword arguments be passed by name #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix style by breaking after open parenthesis. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
dirk-thomas
reviewed
Aug 19, 2019
| *, | ||
| truncate_length: int = None, | ||
| no_arr: bool = False, | ||
| no_str: bool = False) -> str: |
There was a problem hiding this comment.
Nitpick: use single level of indentation here and wrap again before the closing parenthesis.
Same below.
There was a problem hiding this comment.
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
dirk-thomas
approved these changes
Aug 19, 2019
|
CI with ros2/ros2cli#317:
|
jacobperron
added a commit
to ros2/rosidl_runtime_py
that referenced
this pull request
Sep 19, 2019
* Require keyword arguments be passed by name Also fix style by breaking after open parenthesis. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Update style Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix style by breaking after open parenthesis.
Addresses #38 (comment)