Rename TestConfig class to Config to avoid pytest warning #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
|
@dirk-thomas Just curious, was the warning appearing in CI? |
|
Yes, but you only see it in the console output. Jenkins doesn't extract it to show it somewhere prominent. |
|
CI, up to rosidl_runtime_py, only fastrtps:
|
|
The important comparison is the previous warning without this patch: https://ci.ros2.org/job/ci_linux/8010/consoleFull#console-section-179 |
dirk-thomas
approved these changes
Aug 27, 2019
delete-merged-branch
bot
deleted the
ivanpauno/rename-test-config-class
branch
jacobperron
pushed a commit
to ros2/rosidl_runtime_py
that referenced
this pull request
Sep 19, 2019
…l_python#82) Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #78 (comment).