Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move 'noqa: A003' for fields named like a builtin from property to method line #101

Merged
merged 2 commits into from
Mar 19, 2020
Merged

move 'noqa: A003' for fields named like a builtin from property to method line #101

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30c4136
move 'noqa: A003' for fields named like a builtin from property to me…
dirk-thomas Mar 19, 2020
0eff02a
append 'noqa: A003' to both the property as well as the method
dirk-thomas Mar 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rosidl_generator_py/resource/_msg.py.em
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,12 +406,12 @@ if member.name in dict(inspect.getmembers(builtins)).keys():
noqa_string = ' # noqa: A003'
}@
@@property@(noqa_string)
def @(member.name)(self):
def @(member.name)(self):@(noqa_string)
"""Message field '@(member.name)'."""
return self._@(member.name)

@@@(member.name).setter@(noqa_string)
def @(member.name)(self, value):
def @(member.name)(self, value):@(noqa_string)
@[ if isinstance(member.type, AbstractNestedType) and isinstance(member.type.value_type, BasicType) and member.type.value_type.typename in SPECIAL_NESTED_BASIC_TYPES]@
@[ if isinstance(member.type, Array)]@
if isinstance(value, numpy.ndarray):
Expand Down