Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashing backport] remove pad field from py #93

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas commented Nov 25, 2019

Backport of #73. Depends on ros2/rosidl#424.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

* remove the padding member from structs which should be empty

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* update __eq__ logic

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@nuclearsandwich
Copy link
Member

The PR will fail until we release ros2/rosidl#424

@dirk-thomas
Copy link
Member Author

dirk-thomas commented Nov 27, 2019

The PR will fail until we release ros2/rosidl#424

Already in-flight: ros/rosdistro#23175

@dirk-thomas
Copy link
Member Author

With the depenency rosidl being released retriggering the PR job:

@ros-pull-request-builder retest this please

@dirk-thomas dirk-thomas merged commit 4968c0c into dashing Nov 27, 2019
@dirk-thomas dirk-thomas deleted the dirk-thomas/dashing-remove-pad-field-from-py branch November 27, 2019 22:01
@dirk-thomas dirk-thomas moved this from Needs Release to Released in Dashing Patch Release 5 Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants