Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve exception message if value doesn't match expected type #11

Merged
merged 1 commit into from
Mar 31, 2020
Merged

improve exception message if value doesn't match expected type #11

merged 1 commit into from
Mar 31, 2020

Conversation

dirk-thomas
Copy link
Member

Example command:

ros2 topic pub -1 /goal geometry_msgs/PoseStamped '{header: {stamp: now, frame_id: "odom"}, pose: {position: {x: -2.0, y: 2.0, z: 0.0}, orientation: {w: 1.0}}}'

@dirk-thomas
improve exception message if value doesn't match expected type
b7e43c0 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas added the enhancement New feature or request label Mar 30, 2020
@dirk-thomas dirk-thomas self-assigned this Mar 30, 2020
clalancette
clalancette reviewed Mar 30, 2020
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, but otherwise looks good to me.

rosidl_runtime_py/set_message.py Show resolved Hide resolved
@dirk-thomas
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@dirk-thomas dirk-thomas merged commit ad92b96 into master Mar 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/improve-exception-msg branch March 31, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dirk-thomas @clalancette