This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Fix different signedness compiler warning #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, "comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘int’"
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
dirk-thomas
approved these changes
Jan 31, 2020
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
There was a similar set of warnings coming from the cpp generator template, fixed (7f8fb5d) and re-triggered CI. |
dirk-thomas
approved these changes
Jan 31, 2020
|
To check things still work on other platforms (up to test_msgs):
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, "comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘int’"
This should fix many of the warnings seen in https://ci.ros2.org/job/ci_linux/9175/warnings23Result/new/
After:
(down to 212 warnings from 715)