-
Notifications
You must be signed in to change notification settings - Fork 205
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Migrate MarkerArrayDisplay * Fix uncrustify * Extract common code in marker displays into marker_common * Add visual test * Add visual test for MarkerArray messages in MarkerDisplay * Implement review comments * [REMOVE BEFORE MERGE] Fix moved file includes
- Loading branch information
1 parent
41e9e45
commit 467164b
Showing
44 changed files
with
1,218 additions
and
804 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
202 changes: 202 additions & 0 deletions
202
rviz_default_plugins/include/rviz_default_plugins/displays/marker/marker_common.hpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,202 @@ | ||
/* | ||
* Copyright (c) 2008, Willow Garage, Inc. | ||
* Copyright (c) 2018, Bosch Software Innovations GmbH. | ||
* All rights reserved. | ||
* | ||
* Redistribution and use in source and binary forms, with or without | ||
* modification, are permitted provided that the following conditions are met: | ||
* | ||
* * Redistributions of source code must retain the above copyright | ||
* notice, this list of conditions and the following disclaimer. | ||
* * Redistributions in binary form must reproduce the above copyright | ||
* notice, this list of conditions and the following disclaimer in the | ||
* documentation and/or other materials provided with the distribution. | ||
* * Neither the name of the Willow Garage, Inc. nor the names of its | ||
* contributors may be used to endorse or promote products derived from | ||
* this software without specific prior written permission. | ||
* | ||
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" | ||
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE | ||
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE | ||
* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR | ||
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF | ||
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS | ||
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN | ||
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) | ||
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | ||
* POSSIBILITY OF SUCH DAMAGE. | ||
*/ | ||
|
||
#ifndef RVIZ_DEFAULT_PLUGINS__DISPLAYS__MARKER__MARKER_COMMON_HPP_ | ||
#define RVIZ_DEFAULT_PLUGINS__DISPLAYS__MARKER__MARKER_COMMON_HPP_ | ||
|
||
#include <map> | ||
#include <memory> | ||
#include <mutex> | ||
#include <set> | ||
#include <string> | ||
#include <vector> | ||
#include <utility> | ||
|
||
#include <OgreSceneNode.h> | ||
|
||
#include "visualization_msgs/msg/marker.hpp" | ||
#include "visualization_msgs/msg/marker_array.hpp" | ||
|
||
#include "rviz_common/properties/bool_property.hpp" | ||
#include "rviz_common/properties/status_property.hpp" | ||
#include "rviz_common/interaction/forwards.hpp" | ||
|
||
#include "rviz_default_plugins/visibility_control.hpp" | ||
|
||
namespace rviz_common | ||
{ | ||
class Display; | ||
class DisplayContext; | ||
class QueueSizeProperty; | ||
|
||
namespace properties | ||
{ | ||
class IntProperty; | ||
} | ||
} // namespace rviz_common | ||
|
||
using rviz_common::properties::StatusLevel; | ||
|
||
namespace rviz_default_plugins | ||
{ | ||
namespace displays | ||
{ | ||
class MarkerNamespace; | ||
|
||
namespace markers | ||
{ | ||
class MarkerBase; | ||
class MarkerSelectionHandler; | ||
class MarkerFactory; | ||
} | ||
|
||
typedef std::shared_ptr<markers::MarkerSelectionHandler> MarkerSelectionHandlerPtr; | ||
typedef std::shared_ptr<markers::MarkerBase> MarkerBasePtr; | ||
typedef std::pair<std::string, int32_t> MarkerID; | ||
|
||
/** | ||
* \class MarkerCommon | ||
* Common code shared by MarkerDisplay and MarkerArrayDisplay | ||
*/ | ||
class RVIZ_DEFAULT_PLUGINS_PUBLIC MarkerCommon | ||
{ | ||
public: | ||
explicit MarkerCommon(rviz_common::Display * display); | ||
~MarkerCommon(); | ||
|
||
void initialize(rviz_common::DisplayContext * context, Ogre::SceneNode * scene_node); | ||
void load(const rviz_common::Config & config); | ||
|
||
void update(float wall_dt, float ros_dt); | ||
|
||
void deleteMarker(MarkerID id); | ||
|
||
/** @brief Add a new message to the queue, will be drawn on the next update(). */ | ||
void addMessage(visualization_msgs::msg::Marker::ConstSharedPtr marker); | ||
void addMessage(visualization_msgs::msg::MarkerArray::ConstSharedPtr array); | ||
|
||
/** | ||
* \brief Processes a marker message | ||
* @param message The message to process | ||
*/ | ||
void processMessage(visualization_msgs::msg::Marker::ConstSharedPtr message); | ||
|
||
/** | ||
* \brief Removes all the markers | ||
*/ | ||
void clearMarkers(); | ||
|
||
/** @brief Delete all known markers to this plugin, regardless of id or namespace **/ | ||
void deleteAllMarkers(); | ||
|
||
void setMarkerStatus(MarkerID id, StatusLevel level, const std::string & text); | ||
void deleteMarkerStatus(MarkerID id); | ||
|
||
private: | ||
/** @brief Delete all the markers within the given namespace. */ | ||
void deleteMarkersInNamespace(const std::string & ns); | ||
|
||
/** | ||
* \brief Processes an "Add" marker message | ||
* @param message The message to process | ||
*/ | ||
void processAdd(visualization_msgs::msg::Marker::ConstSharedPtr message); | ||
/** | ||
* \brief Processes a "Delete" marker message | ||
* @param message The message to process | ||
*/ | ||
void processDelete(visualization_msgs::msg::Marker::ConstSharedPtr message); | ||
|
||
typedef std::vector<visualization_msgs::msg::Marker::ConstSharedPtr> V_MarkerMessage; | ||
V_MarkerMessage takeSnapshotOfMessageQueue(); | ||
void processNewMessages(const V_MarkerMessage & local_queue); | ||
void removeExpiredMarkers(); | ||
|
||
void updateMarkersWithLockedFrame() const; | ||
QHash<QString, MarkerNamespace *>::const_iterator getMarkerNamespace( | ||
const visualization_msgs::msg::Marker::ConstSharedPtr & message); | ||
MarkerBasePtr createOrGetOldMarker( | ||
const visualization_msgs::msg::Marker::ConstSharedPtr & message); | ||
MarkerBasePtr createMarker(const visualization_msgs::msg::Marker::ConstSharedPtr & message); | ||
void configureMarker( | ||
const visualization_msgs::msg::Marker::ConstSharedPtr & message, MarkerBasePtr & marker); | ||
|
||
typedef std::map<MarkerID, MarkerBasePtr> M_IDToMarker; | ||
typedef std::set<MarkerBasePtr> S_MarkerBase; | ||
M_IDToMarker markers_; ///< Map of marker id to the marker info structure | ||
S_MarkerBase markers_with_expiration_; | ||
S_MarkerBase frame_locked_markers_; | ||
///< Marker message queue. Messages are added to this as they are received, and then processed | ||
///< in our update() function | ||
V_MarkerMessage message_queue_; | ||
std::mutex queue_mutex_; | ||
|
||
typedef QHash<QString, MarkerNamespace *> M_Namespace; | ||
M_Namespace namespaces_; | ||
|
||
rviz_common::properties::Property * namespaces_category_; | ||
|
||
typedef std::map<QString, bool> M_EnabledState; | ||
M_EnabledState namespace_config_enabled_state_; | ||
|
||
std::unique_ptr<markers::MarkerFactory> marker_factory_; | ||
|
||
rviz_common::Display * display_; | ||
rviz_common::DisplayContext * context_; | ||
Ogre::SceneNode * scene_node_; | ||
|
||
friend class MarkerNamespace; | ||
}; | ||
|
||
/** @brief Manager of a single marker namespace. Keeps a hash from | ||
* marker IDs to MarkerBasePtr, and creates or destroys them when necessary. */ | ||
class RVIZ_DEFAULT_PLUGINS_PUBLIC MarkerNamespace : public rviz_common::properties::BoolProperty | ||
{ | ||
Q_OBJECT | ||
|
||
public: | ||
MarkerNamespace( | ||
const QString & name, | ||
rviz_common::properties::Property * parent_property, | ||
MarkerCommon * owner | ||
); | ||
bool isEnabled() const {return getBool();} | ||
|
||
public Q_SLOTS: | ||
void onEnableChanged(); | ||
|
||
private: | ||
MarkerCommon * owner_; | ||
}; | ||
|
||
} // namespace displays | ||
} // namespace rviz_default_plugins | ||
|
||
#endif // RVIZ_DEFAULT_PLUGINS__DISPLAYS__MARKER__MARKER_COMMON_HPP_ |
Oops, something went wrong.