Include MeshShape class #1064
Merged
Include MeshShape class #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
clalancette
requested changes
Oct 17, 2023
There was a problem hiding this comment.
This is a minor point, but I kind of feel like this file should be in the objects subdirectory. That is, it seems to be an object in its own right, and basically everything else that derives from Shape is in the object subdirectory.
@ahcorde What do you think?
Comment on lines
35
to
38
| namespace Ogre | ||
| { | ||
| class ManualObject; | ||
| } |
There was a problem hiding this comment.
Instead of doing this, can we just #include the appropriate Ogre header? We should also probably add includes for SceneNode, Vector3, SceneManager, etc in here as well.
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
|
clalancette
approved these changes
Oct 30, 2023
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with this issue: #763