Fix up warnings when building with clang. #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that clang defines __GNUC__, but doesn't understand all of the flags that GCC does. Thus, make the pushing and popping of flags conditional on GCC only. While we are in here, remove some bits of workarounds that are no longer necessary. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
CI:
|
|
Clang build:
|
ahcorde
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that clang defines GNUC, but doesn't understand all of the flags that GCC does. Thus, make the pushing and popping of flags conditional on GCC only.
While we are in here, remove some bits of workarounds that are no longer necessary.