Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix splash screen and help panel #277

Merged
merged 8 commits into from
Jun 14, 2018

Conversation

botteroa-si
Copy link
Contributor

Closes #59.

With this PR the splash screen (with the relative command line option) and the help panel are re-enabled.
For what concerns the help panel content, the information about not yet ported tools and view controllers has been commented out for the moment.

@botteroa-si
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood wjwwood added the in review Waiting for review (Kanban column) label Jun 6, 2018
@wjwwood wjwwood added this to the bouncy milestone Jun 6, 2018
@botteroa-si
Copy link
Contributor Author

botteroa-si commented Jun 6, 2018

@wjwwood, the failing of Linux and macOS seems unrelate to our changes. Here a new CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood wjwwood added the 🔥 label Jun 12, 2018
@botteroa-si botteroa-si force-pushed the feature/fix_splash_screen_and_help_panel branch from 1b2223c to b0f9f86 Compare June 12, 2018 12:27
@botteroa-si
Copy link
Contributor Author

New CI after the non trivial rebase:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Martin-Idel-SI Martin-Idel-SI force-pushed the feature/fix_splash_screen_and_help_panel branch from b0f9f86 to 19a65d7 Compare June 13, 2018 09:22
@Martin-Idel-SI
Copy link
Contributor

Martin-Idel-SI commented Jun 13, 2018

CI after rebase:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

New mac:

  • macOS Build Status

@wjwwood wjwwood merged commit 3b092bc into ros2:ros2 Jun 14, 2018
@clalancette clalancette removed the in review Waiting for review (Kanban column) label Jun 14, 2018
@anhosi anhosi deleted the feature/fix_splash_screen_and_help_panel branch June 14, 2018 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants