Migrate point stamped display #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greimela-si
force-pushed
the
feature/migrate_point_stamped
branch
from
15b29b5
to
4a11f52
Compare
|
CI after rebase:
|
|
@Martin-Idel-SI you probably noticed already but you'll need to update your repos file to include ros2/ros2#488 |
|
@dhood: Thanks. Yes, I noticed. Here is a new CI:
|
- The visual doesn't do anything but delegate to Shape - It was meant to be expanded, but that didn't happen in four years
anhosi
force-pushed
the
feature/migrate_point_stamped
branch
from
4a11f52
to
ec01b81
Compare
|
New CI after rebase (restricted to rviz):
|
wjwwood
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #83
Note that I completely deleted the "point_visual", since it was just a wrapper around a sphere shape.
CI:
EDIT: MacBuild not our failure, but here is a new one: