Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate fps camera #281

Merged
merged 7 commits into from
Jun 14, 2018
Merged

Migrate fps camera #281

merged 7 commits into from
Jun 14, 2018

Conversation

Martin-Idel-SI
Copy link
Contributor

@Martin-Idel-SI Martin-Idel-SI commented Jun 6, 2018 •
edited
Loading

Closes #217

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood wjwwood added in review Waiting for review (Kanban column) 🔥 labels Jun 11, 2018
@Martin-Idel-SI
Copy link
Contributor Author

Martin-Idel-SI commented Jun 12, 2018 •
edited
Loading

CI after rebase:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Martin-Idel-SI
Copy link
Contributor Author

CI after rebase:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

wjwwood
wjwwood approved these changes Jun 14, 2018
View reviewed changes
rviz_default_plugins/CMakeLists.txt
${TEST_LINK_LIBRARIES})
endif()

if(EnableVisualTests STREQUAL "True")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: indentation looks wrong here. Could be fixed in a small follow up pr.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be done on the open PR #289

@wjwwood wjwwood merged commit f89711b into ros2:ros2 Jun 14, 2018
@clalancette clalancette removed the in review Waiting for review (Kanban column) label Jun 14, 2018
@anhosi anhosi deleted the feature/migrate_fps_camera branch June 14, 2018 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees
No one assigned
Labels
🔥
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Martin-Idel-SI @wjwwood @clalancette