Migrate XYOrbitViewController #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martin-Idel-SI
force-pushed
the
feature/migrate_xy_orbit_camera
branch
from
fa3e7f9
to
d731a5b
Compare
|
We added two small fixes and rebased onto current master. So a new CI is in order:
|
|
@Martin-Idel-SI FYI, your macOS build failed because of a Jenkins disconnect, and then the restart of it happened to get onto a node that is having trouble right now. I've killed off the new job, so it would probably be best if you kick off a new macOS job on the build farm by hand. Sorry for the disruption. |
|
@clalancette Thanks for the explanation. I'll restart:
|
- This is necessary to allow consolidated test setup
- leads to segfault: The default constructor of Ogre types does not set to zero
wjwwood
force-pushed
the
feature/migrate_xy_orbit_camera
branch
from
d731a5b
to
8901ee6
Compare
wjwwood
approved these changes
Jun 12, 2018
|
I built and tested the controller out locally (on my macbook), looks good there too. CI (using
|
|
Missed a cpplint issue:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #219
This PR migrates the XYOrbitViewController and also updates the OrbitViewController.
In particular, we worked on consistency in "mimic" again, working with the originally intended behaviour.
We tried to enable "mimic" behaviour also when the camera was below the xy-plane, but didn't manage to have it working as above the xy-plane (sadly, it's not a symmetric problem).
CI: