Polish tests and migrate or delete old tests #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI:
|
anhosi
force-pushed
the
feature/polish_and_port_tests
branch
from
8f1b150
to
89e7678
Compare
|
new CI after rebase:
|
|
Restarting mac build due to Jenkins NLP connection error:
|
Martin-Idel-SI
force-pushed
the
feature/polish_and_port_tests
branch
from
89e7678
to
7fee156
Compare
|
CI after rebase:
|
wjwwood
added
in progress
Merged
wjwwood
added
in review
- All tests have been superseded by unit or visual tests
The resources were used in a first stage of testing selection manager
- if this test fails, it doesn't really say anything about rviz anymore - all visual tests would fail if this failed, so we would catch the error - scene_graph introspection tests that are already there also give much more information on what went wrong
- remove superfluous gtest include when gmock is already included - adjust style of commits
- this was previously not caught by RViz, although a test was present to test against it - delete this test (now automated)
- when adding properties, tests will not suddenly fail - makes the test more explicit
- The "connect_test" is actually a benchmark which documents something about how to use signals. - The new_display_dialog_test seems to have hardly anything to do with rviz anymore - The color_editor_test is no well documented test. Manual tests should be documented
Martin-Idel-SI
force-pushed
the
feature/polish_and_port_tests
branch
from
7fee156
to
182992d
Compare
|
CI after rebase:
|
wjwwood
approved these changes
Jun 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following: