Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish tests and migrate or delete old tests #289

Merged
merged 12 commits into from Jun 16, 2018

Commits on Jun 15, 2018

  1. Delete superfluous tests and files

    - All tests have been superseded by unit or visual tests
    Martin-Idel-SI committed Jun 15, 2018
    Copy the full SHA
    e1be827 View commit details
    Browse the repository at this point in the history
  2. Delete leftover test resources in rviz_common

    The resources were used in a first stage of testing selection manager
    Martin-Idel-SI committed Jun 15, 2018
    Copy the full SHA
    fc7c64e View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    f415215 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    6a33381 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    d00e0d1 View commit details
    Browse the repository at this point in the history
  6. Cleanup CMakelists

    Martin-Idel-SI committed Jun 15, 2018
    Copy the full SHA
    ab19ccf View commit details
    Browse the repository at this point in the history
  7. Delete superfluous rendering test

    - if this test fails, it doesn't really say anything about rviz anymore
    - all visual tests would fail if this failed, so we would catch the error
    - scene_graph introspection tests that are already there also give much more information on what went wrong
    Martin-Idel-SI committed Jun 15, 2018
    Copy the full SHA
    5bc819f View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    5f7b759 View commit details
    Browse the repository at this point in the history
  9. Polish includes in tests

    - remove superfluous gtest include when gmock is already included
    - adjust style of commits
    Martin-Idel-SI committed Jun 15, 2018
    Copy the full SHA
    eae72c6 View commit details
    Browse the repository at this point in the history
  10. Write test with wrong pointcloud data

    - this was previously not caught by RViz, although a test was present to test against it
    - delete this test (now automated)
    Martin-Idel-SI committed Jun 15, 2018
    Copy the full SHA
    281e204 View commit details
    Browse the repository at this point in the history
  11. Use findProperty instead of childAt where possible

    - when adding properties, tests will not suddenly fail
    - makes the test more explicit
    Martin-Idel-SI committed Jun 15, 2018
    Copy the full SHA
    cae549b View commit details
    Browse the repository at this point in the history
  12. Delete potentially superfluous tests

    - The "connect_test" is actually a benchmark which documents something about how to use signals.
    - The new_display_dialog_test seems to have hardly anything to do with rviz anymore
    - The color_editor_test is no well documented test. Manual tests should be documented
    Martin-Idel-SI committed Jun 15, 2018
    Copy the full SHA
    182992d View commit details
    Browse the repository at this point in the history