Migrate 2D Nav Goal tool #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI:
|
wjwwood
added
in progress
botteroa-si
force-pushed
the
feature/migrate_nav_goal_tool
branch
2 times, most recently
from
db268f9
to
6e1ba86
Compare
Merged
|
New CI after rebase:
|
|
@wjwwood, as for the PR #295, we added the last commit (6e1ba86) only the make the tests pass. This commit resolves an undetected merge error from last night and will be published as a pr of its own. The last commit will cause a conflict once the other pr is merged. Simply remove the last commit from this pr before merging will work. |
botteroa-si
force-pushed
the
feature/migrate_nav_goal_tool
branch
from
6e1ba86
to
f7d64a4
Compare
wjwwood
approved these changes
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #215.
This PR consists of the migration of the Goal Tool (together with the Pose tool), the addition of tests and refactoring.
In particular, we also slightly changed the behaviour of the tool when one, after having clicked on the xy plane, releases the mouse in a point that doesn't intersect this plane: in RViz 1 the green arrow generated by the Pose Tool would just stay visible and the nav goal tool would remain selected, until a new mouse click event happens. Now the pose message is published using the current orientation of the Pose Tool arrow. (This fix also prevents an assert to fail and RViz to crash).