Migrate ThirdPersonFollowerViewController #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI:
|
greimela-si
changed the title
wjwwood
added
in progress
anhosi
force-pushed
the
feature/migrate_third_person_follower_view_controller
branch
from
d081088
to
7b3fd24
Compare
|
New CI after rebase:
|
|
@wjwwood We added the last commit (7b3fd24) only the make the tests pass. This commit resolves an undetected merge error from last night and will be published as a pr of its own. The last commit will cause a conflict once the other pr is merged. Simply remove the last commit from this pr before merging will work. |
Merged
wjwwood
added
in review
wjwwood
approved these changes
Jun 15, 2018
Martin-Idel-SI
deleted the
feature/migrate_third_person_follower_view_controller
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the
ThirdPersonFollowerViewControllerto ros2/rviz.Closes #220.
Note: The first commit contains the required fix from #293, remove this commit after the fix has been merged!