Add hotkeys (also to help) #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI:
|
Martin-Idel-SI
force-pushed
the
feature/add_missing_hotkeys
branch
2 times, most recently
from
92f64cb
to
9e1feb4
Compare
|
CI after rebase:
|
greimela-si
force-pushed
the
feature/add_missing_hotkeys
branch
from
9e1feb4
to
0d274d3
Compare
|
CI after rebase:
|
wjwwood
force-pushed
the
ros2
branch
2 times, most recently
from
5997b63
to
5872a16
Compare
Martin-Idel-SI
force-pushed
the
feature/add_missing_hotkeys
branch
from
0d274d3
to
5c89d87
Compare
wjwwood
reviewed
Aug 2, 2018
| @@ -73,6 +73,8 @@ FocusTool::~FocusTool() = default; | |||
|
|
|||
| void FocusTool::onInitialize() | |||
| { | |||
| shortcut_key_ = 'c'; | |||
There was a problem hiding this comment.
Should this be in the constructor like the other two?
| @@ -58,6 +58,8 @@ namespace tools | |||
| MeasureTool::MeasureTool() | |||
| : is_line_started_(false), length_(-1) | |||
| { | |||
| shortcut_key_ = 'n'; | |||
There was a problem hiding this comment.
Should all of these be part of the member initialization section? : is_line_..., shurtcut_key_('n')?
There was a problem hiding this comment.
The problem is that they are protected members of the rviz_common::Tool class, so I can't do that - I would have to provide another non-default constructor for Tool.
There is a comment for the Tool constructor saying that the shortcut_key_ member should be initialized in the constructor.
Martin-Idel-SI
force-pushed
the
feature/add_missing_hotkeys
branch
from
5c89d87
to
329947a
Compare
|
CI after rebase and fixes:
|
wjwwood
approved these changes
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #304
Also added hotkeys to help description to make discovery easy.
Note: This PR should probably only be merged when a corresponding PR is merged with ros-visualization/rviz