Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make status non editable #316

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Make status non editable #316

merged 1 commit into from
Jun 21, 2018

Conversation

Martin-Idel-SI
Copy link
Contributor

Currently, any status property can be edited. There is no reason for that, so this PR makes them not editable.

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Jun 21, 2018
@Martin-Idel-SI
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood wjwwood merged commit 75fa255 into ros2:ros2 Jun 21, 2018
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Jun 21, 2018
@greimela-si greimela-si deleted the bugfix/make_status_non_editable branch June 25, 2018 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Martin-Idel-SI @wjwwood @dirk-thomas