Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreliable option for topics #360

Closed
Myzhar opened this issue Oct 9, 2018 · 1 comment · Fixed by #409
Closed

Unreliable option for topics #360

Myzhar opened this issue Oct 9, 2018 · 1 comment · Fixed by #409
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Myzhar
Copy link

Myzhar commented Oct 9, 2018

I noticed that the Unrealiable option for the new Rviz continues to report "Prefer UDP topic transport" that I think is no more correct.

According to the DDS I think that all the Unreliable options should be splitted in two different options as combo boxes, one for Reliability and one for Durability, allowing to select Best effort or Reliable and Transient local or Volatile.

In this way you can let the user configure a subscriber that is compatible with the QOS profile of the publisher.

Ref: https://github.com/ros2/ros2/wiki/About-Quality-of-Service-Settings

@wjwwood
Copy link
Member

wjwwood commented Oct 9, 2018

Agreed, it was probably just overlooked during migration. A pull request to update this would be appreciated.

/cc @anhosi this might be something for contribution by a new contributor

@wjwwood wjwwood added enhancement New feature or request help wanted Extra attention is needed labels Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants