Propagate toolchain-file to external-project #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If defined, propagate the CMAKE_TOOLCHAIN_FILE argument to the cmake argument of freetype, zlib and ogre projects. Change-Id: Ibf2802b96c2238a06191e78a1b2a3128769a83af Signed-off-by: Louis Mayencourt <louis.mayencourt@arm.com>
wjwwood
added
in review
|
Thanks for the pr, does this need to be done for the other vendor packages? |
|
Some of them already have the same test: libyaml_vendor, poco_vendor, console_bridge_vendor and uncrustify_vendor. |
|
Ok, maybe you can let me know when you've gotten father along and then I can review merge this pr? Or would you prefer to get this one merged and do follow prs? My preference is slightly for the single pr since each one takes some time. |
|
I prefer single pr, as I don't think we will need to modify other vendor packages |
|
Ok, here's CI then:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If defined, propagate the CMAKE_TOOLCHAIN_FILE argument to the cmake argument of freetype, zlib and ogre projects.