Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix install destination of OGRE media resources which contain a dirname #404

Merged
merged 1 commit into from
May 23, 2019
Merged

fix install destination of OGRE media resources which contain a dirname #404

merged 1 commit into from
May 23, 2019

Conversation

dirk-thomas
Copy link
Member

Fixes #403.

@dirk-thomas dirk-thomas added bug Something isn't working in review Waiting for review (Kanban column) labels May 22, 2019
@dirk-thomas dirk-thomas self-assigned this May 22, 2019
@dirk-thomas dirk-thomas merged commit b425aeb into ros2 May 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/fix403 branch May 23, 2019 16:23
dirk-thomas added a commit that referenced this pull request May 24, 2019
@dirk-thomas
update test to match changes from #404
b2f37b9
@dirk-thomas
Copy link
Member Author

The follow up commit b2f37b9 updates the unit test to check for the corrected path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

@skucheria skucheria Awaiting requested review from skucheria

Assignees

@dirk-thomas dirk-thomas

Labels
bug Something isn't working in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect path for ogre_media_resources/scripts on rviz launch
2 participants
@dirk-thomas @nuclearsandwich