FrameTransformer implements tf2::BufferCoreInterface and tf2_ros::AsyncBufferInterface #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 2, 2019
jacobperron
added
in review
|
Ready for review. |
jacobperron
force-pushed
the
jacob/frame_transformer
branch
from
a1f367b
to
4f6b913
Compare
…s::AsyncBufferInterface This lets FrameTransformer plugins easily passed to tf2_ros::MessageFilter. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Lint * Combine canTransform tests Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
…ameTransformer This shortcuts the conversions to/from RViz types. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
force-pushed
the
jacob/frame_transformer
branch
from
4f6b913
to
4d099c3
Compare
wjwwood
approved these changes
Jul 18, 2019
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
wjwwood
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires ros2/geometry2#121
Unblocks #375
The idea is to have
rviz_common::transformation::FrameTransformerplugins implement the interfaces required bytf2_ros::MessageFilter. This will enable us to pass any frame transformers to the TF message filter.I'm opening this for visibility. The implementation is subject to change pending the review of ros2/geometry2#121. I also would like to refactor this so that we avoid the extra conversion to/from rviz and tf2 types in the case we are using a TFFrameTransformer.