Use geometry_msgs types instead of custom types #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we depend on and use geometry_msgs (via tf2) anyways, this change eliminates unnecessary conversions. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
wjwwood
approved these changes
Jul 10, 2019
Edit: oops, missed an include that was cached in my workspace. Re-triggered with 1d211e6 |
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we depend on and use geometry_msgs (via tf2) anyways, this change eliminates unnecessary conversions.
This should also help simplify changes in #422