Add icon copyrights + PoseWithCovariance icon #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix formatting of README.md * remove footnote notation that was unused
* Added missing PoseWithCovariance icon * Added icon author
wjwwood
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #408
I cherry-picked the commits introducing the icon copyrights from the upstream ros-visualization fork. That way, the original authors are preserved. I only deleted the Github issue numbers as they would point to the wrong issues.
In addition, I cherry-picked the commit adding an icon for the PoseWithCovariance display (I have it ported and will provide a PR once this gets merged).
I still think that the "Public Domain" license should be switched to CC0 (which is identical wherever Public Domain exists but provides a valid license wherever it doesn't), but this is a maintainer decision of course.