Migrate pose with covariance display #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- extract selection handler (shorten name due to include guards) - make code closer to pose display code - common code (also with odometry display) could be extracted
|
CI:
|
|
Looks like there's a build failure on the Windows CI, maybe symbol visibility related? |
|
@wjwwood Yes, definitely. Hopefully the additions already fix everything, I don't have a Windows to test right now. Maybe we should add |
|
Thanks, CI:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #87
Icon is missing, this was already proposed as a PR here: #430
As always: Added a visual test - I adapted test and page objects from the odometry display ones and therefore kept the copyrights from those files, too, and left a comment that those are basically copy&paste.
There is a lot of common code between this display, the pose display and the pose array display. It could be refactored, but that would make this PR really large and difficult to review, so I would suggest to do this separately. Here, I only brought the display as close to the pose display code as possible.