Fix map after upgrade #459
Conversation
The shader was incomplete: Without declaring textures, of the texture is assumed to be 2d, which is incompatible with the fragment shader sampler1d variable. Previously, this did not manifest at all because no texture units were assigned while now they may be
Previously the old texture was replaced but not rebound. Now we only delete the texture when actually binding it to the shader unit state
This might cause problems because Ogre vectors are not initialised
|
Fixes issue on my machine |
There was a problem hiding this comment.
Though the map is rendering for me now, I do get the following error printed to the screen when the first map message is received:
[ERROR] [rviz2]: Vertex Program:rviz/glsl120/indexed_8bit_image.vert Fragment Program:rviz/glsl120/indexed_8bit_image.frag GLSL link result :
active samplers with a different type refer to the same texture image unit
I'm not sure what is causing it.
rviz_default_plugins/src/rviz_default_plugins/displays/map/swatch.cpp
Outdated
Show resolved
Hide resolved
|
@jacobperron: Yes, I also see this message, but actually I also see it without the upgrade. The message seems to be present for other people as well before the upgrade (for instance, see #458 - whatever version was used there, it was definitely before the OGRE upgrade, because the log message reads "Creating 1 swatches_" which was changed in d52e5c1 before the upgrade). I tried to get rid of that message also, but I couldn't do it without going really deep and as it was present before the upgrade, it seems to be a different problem. |
There was a problem hiding this comment.
I tried to get rid of that message also, but I couldn't do it without going really deep and as it was present before the upgrade, it seems to be a different problem.
Okay, perhaps we should open an issue regarding the error message for visibility.
- Linux
- Linux-aarch64
- macOS
- Windows
|
Follow-up ticket: #463 |
Fix #453
This fixes the visual test after the latest upgrade and should therefore fix map rendering in general. Now, I only see one instance of
in the log, but I also see this way before the upgrade was done, so it's a different issue altogether.