Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rviz_rendering] add glsl resources and test with / fix glsl 150 #46

Open
wjwwood opened this issue Sep 27, 2017 · 2 comments
Open

[rviz_rendering] add glsl resources and test with / fix glsl 150 #46

wjwwood opened this issue Sep 27, 2017 · 2 comments
Labels
enhancement New feature or request

Comments

@wjwwood
Copy link
Member

wjwwood commented Sep 27, 2017

See:

// TODO(wjwwood): figure out why includes don't work on 150

@wjwwood wjwwood added help wanted Extra attention is needed enhancement New feature or request and removed help wanted Extra attention is needed labels Sep 27, 2017
@Martin-Idel-SI
Copy link
Contributor

Maybe we can try to help, but could you maybe clarify the issue? On my Ubuntu with NVidia graphics card, I get OpenGL 4.5 and thus glsl >150 and there seems to be no issue. Resources seem to get added and I have no error or warning. What exactly is supposed to happen or not happen? Thank you.

@wjwwood
Copy link
Member Author

wjwwood commented Oct 6, 2017

@Martin-Idel-SI Sure, sorry for not having more details in the original issue. I was getting issues specifically with the // include in the glsl scripts, because ogre would parse the comment, then try to find the resource using the Ogre::ResourceManager thing and that was failing.

Here's an example of one of the include comments:

https://github.com/ros2/rviz/blob/ros2/rviz/ogre_media/materials/glsl120/glsl120.program#L2-L5

I'd have to move that folder to rviz_rendering again and try to reenable the loading of those to see the issue again. I can try to setup a branch with that on it for you tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants