Allow the MapDisplay "Update Topic" to be changed. #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The major reason for this is so that the "Update Topic" (and more importantly the QoS profile) is saved when clicking "Save Config" in RViz2. The more minor reason is that a user *might* want to use a different topic for this. We still auto-populate this field with <topic_name>_updates by default, but the user can now override it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
@wjwwood Any thoughts on this change? Otherwise I'll run CI on it. |
wjwwood
approved these changes
Mar 11, 2020
|
CI:
|
|
The macOS warning was also in the nightlies, and is unrelated to this change. So I'm going to merge, thanks for the reviews. |
clalancette
added a commit
that referenced
this pull request
Mar 12, 2020
The major reason for this is so that the "Update Topic" (and more importantly the QoS profile) is saved when clicking "Save Config" in RViz2. The more minor reason is that a user *might* want to use a different topic for this. We still auto-populate this field with <topic_name>_updates by default, but the user can now override it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
wjwwood
pushed a commit
that referenced
this pull request
Mar 12, 2020
The major reason for this is so that the "Update Topic" (and more importantly the QoS profile) is saved when clicking "Save Config" in RViz2. The more minor reason is that a user *might* want to use a different topic for this. We still auto-populate this field with <topic_name>_updates by default, but the user can now override it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major reason for this is so that the "Update Topic"
(and more importantly the QoS profile) is saved when clicking
"Save Config" in RViz2. The more minor reason is that a user
might want to use a different topic for this. We still
auto-populate this field with <topic_name>_updates by default,
but the user can now override it.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
@IanTheEngineer FYI