remove duplicate include dirs and link libraries #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
sloretz
reviewed
Apr 28, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
|
Full set of CI builds with only this PR:
|
sloretz
reviewed
Apr 29, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
|
See latest builds on ament/ament_cmake#251. |
wjwwood
approved these changes
Apr 30, 2020
There was a problem hiding this comment.
lgtm assuming @sloretz's concern has been addressed, which it seems like is the case given the CI on ament/ament_cmake#251 (comment)
sloretz
approved these changes
Apr 30, 2020
delete-merged-branch
bot
deleted the
dirk-thomas/use-targets-over-interfaces-over-classic-vars-2
branch
rotu
added a commit
to RoverRobotics-forks/rviz
that referenced
this pull request
Apr 30, 2020
Resolve merge conflicts from ros2#533
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the repeated include dirs / libraries exceed the maximum command line length for the linker invocation (together with ament/ament_cmake#251).
It might also help to make the packaging job turn over again.