Fix for mousewheel to zoom in/out #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
|
Hi, @jacobperron From rviz/rviz_common/include/rviz_common/viewport_mouse_event.hpp Lines 95 to 96 in 323378a and message in the status bar "Right-Click/Mouse Wheel:: Zoom. ", I think we need to use e->angleDelta().y() to instead of e->angleDelta().x() in
. (Of course, we can also update the comment "/// Angle that the common horizontal mouse wheel was rotated " and tip message, such as "Right-Click/Alt+Mouse Wheel:: Zoom. ".)
NOTE: https://doc.qt.io/qt-5/qwheelevent.html#angleDelta (angleDelta().y() provides the angle through which the common vertical mouse wheel was rotated since the previous event) |
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
|
friendly ping @jacobperron 🔕 |
jacobperron
approved these changes
Nov 13, 2020
Merged
|
jacobperron
pushed a commit
that referenced
this pull request
Nov 13, 2020
* Fix for mousewheel to zoom in/out Signed-off-by: Chen Lihui <Lihui.Chen@sony.com> * Use vertical mouse wheel to test Signed-off-by: Chen Lihui <lihui.chen@sony.com>
jacobperron
added a commit
that referenced
this pull request
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #605
Signed-off-by: Chen Lihui Lihui.Chen@sony.com