Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for namespace-scoped DELETEALL action in Marker displays. #685

Merged
merged 2 commits into from
May 13, 2021
Merged

Add support for namespace-scoped DELETEALL action in Marker displays. #685

merged 2 commits into from
May 13, 2021

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented May 11, 2021 •
edited
Loading

Closes #684. Besides the integration test included in this patch, I've manually tested this works as intended in a local build.

CI up to rviz_default_plugins:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic
Add support for namespace-scoped DELETEALL action in Marker displays.
a07562d 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Add test case for namespace-scoped DELETEALL action in Marker displays.
6a7be70 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic mentioned this pull request May 11, 2021
Closed
jacobperron
jacobperron reviewed May 12, 2021
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature sounds good to me. I think we should document this somewhere, maybe in the message definition here and/or here.

@hidmic hidmic mentioned this pull request May 12, 2021
Merged
@hidmic
Copy link
Contributor Author

hidmic commented May 12, 2021

I think we should document this somewhere

Done in ros2/common_interfaces#151. PTAL.

@hidmic
Copy link
Contributor Author

hidmic commented May 13, 2021

Going in!

@hidmic hidmic merged commit f61c164 into ros2 May 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the hidmic/namespace-scoped-marker-delete branch May 13, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

@mjeronimo mjeronimo Awaiting requested review from mjeronimo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Namespace-scoped Marker DELETEALL action
2 participants
@hidmic @jacobperron