Don't attempt to moc generate files that don't have QOBJECT. #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a warning. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
CI:
|
ahcorde
requested changes
May 24, 2021
There was a problem hiding this comment.
do we need a tf2 release https://build.ros2.org/job/Rpr__rviz__ubuntu_focal_amd64/123/console ?
Yeah, I think we do. I was holding off because of some other stuff going on there (particularly ros2/geometry2#420). |
wjwwood
approved these changes
May 24, 2021
ahcorde
approved these changes
May 26, 2021
|
I'm going to go ahead and merge this, because the failing PR job is not because of this. Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a warning.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
This removes a warning seen on Linux that looks like:
for each of the two files.