Handle NaN values for Wrench msgs #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
destogl
suggested changes
Aug 18, 2021
rviz_default_plugins/src/rviz_default_plugins/displays/wrench/wrench_display.cpp
Outdated
Show resolved
Hide resolved
rviz_default_plugins/src/rviz_default_plugins/displays/wrench/wrench_display.cpp
Outdated
Show resolved
Hide resolved
| @@ -96,6 +100,7 @@ void WrenchDisplay::reset() | |||
|
|
|||
| void WrenchDisplay::updateWrenchVisuals() | |||
| { | |||
| // bool accept_NaN = accept_NaN_values_->getBool(); | |||
There was a problem hiding this comment.
why is this commented out?
There was a problem hiding this comment.
This is kept as part of testing, will remove.
rviz_default_plugins/include/rviz_default_plugins/displays/wrench/wrench_display.hpp
Outdated
Show resolved
Hide resolved
rviz_default_plugins/src/rviz_default_plugins/displays/wrench/wrench_display.cpp
Outdated
Show resolved
Hide resolved
rviz_default_plugins/src/rviz_default_plugins/displays/wrench/wrench_display.cpp
Outdated
Show resolved
Hide resolved
| return; | ||
| } | ||
| } else { | ||
| custom_msg->wrench.force.x = (std::isnan(msg->wrench.force.x)) ? 0.0 : msg->wrench.force.x; |
There was a problem hiding this comment.
You should also validate if message has inf in it. Use again validate for this and then if true check if there are only NaNs and if not than do nothing/ignore message.
There was a problem hiding this comment.
sure, will add the validate part,
…wrench_display.cpp Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
…wrench_display.cpp Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
…wrench_display.cpp Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
…nch/wrench_display.hpp Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
…wrench_display.cpp Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
|
This new option 'Accept NaN Values' looks like this.
|
destogl
reviewed
Aug 19, 2021
rviz_default_plugins/src/rviz_default_plugins/displays/wrench/wrench_display.cpp
Outdated
Show resolved
Hide resolved
rviz_default_plugins/src/rviz_default_plugins/displays/wrench/wrench_display.cpp
Outdated
Show resolved
Hide resolved
|
@bmagyar can you also give it a look before we trigger RViz-maintainers |
bmagyar
approved these changes
Aug 25, 2021
|
ahcorde
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems in Rviz
This PR will contain the changes to,