Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TF filter from ImageTransportDisplay #788

Merged
merged 2 commits into from
Jan 13, 2022
Merged

Remove TF filter from ImageTransportDisplay #788

merged 2 commits into from
Jan 13, 2022

Conversation

jacobperron
Copy link
Member

Fixes #639

Only the CameraDisplay cares about TF data, so this change moves the TF filter logic into the CameraDisplay.

This allows users to view images with the ImageDisplay no matter what the fixed frame is set to.

@jacobperron
Remove TF filter from ImageTransportDisplay
1b9057d 
Fixes #639

Only the CameraDisplay cares about TF data, so this change moves the TF filter logic into the CameraDisplay.

This allows users to view images with the ImageDisplay no matter what the fixed frame is set to.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron self-assigned this Oct 28, 2021
@jacobperron jacobperron added this to Proposed in Foxy Patch Release 7 via automation Oct 28, 2021
@jacobperron
Copy link
Member Author

This isn't an ABI-compatible fix, but I have some ideas for workarounds to fix the behavior in Galactic and Foxy.

This was referenced Oct 28, 2021
Closed
Merged
@jacobperron
Copy link
Member Author

This isn't an ABI-compatible fix, but I have some ideas for workarounds to fix the behavior in Galactic and Foxy.

Well, Galactic and Foxy actually don't use ImageTransportDisplay, and instead use MessageFilterDisplay. This appears to make it difficult to fix the issue in an ABI-compatible way. Perhaps it's reasonable to break ABI for ImageDisplay by doing something like #781.

@jacobperron
Uncrustify
80db055 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit f8e8163 into ros2 Jan 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the jacob/fix_639 branch January 13, 2022 20:55
@jacobperron jacobperron removed this from Proposed in Galactic Patch Release 2 Jan 31, 2022
@jacobperron jacobperron removed this from Proposed in Foxy Patch Release 7 Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

@ahcorde ahcorde Awaiting requested review from ahcorde ahcorde is a code owner

@mjeronimo mjeronimo Awaiting requested review from mjeronimo

Assignees

@jacobperron jacobperron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add configuration for Image to be shown without proper TF/fixed frame
2 participants
@jacobperron @wjwwood