Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export image_transport dependency #813

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

iuhilnehc-ynos
Copy link

When I build the nav2_rviz_plugins package which depends on rviz_default_plugins, it failed as follows,

--- stderr: nav2_rviz_plugins                                                                                                       
CMake Error at CMakeLists.txt:50 (add_library):
  Target "nav2_rviz_plugins" links to target
  "image_transport::image_transport" but the target was not found.  Perhaps a
  find_package() call is missing for an IMPORTED target, or an ALIAS target
  is missing?

I think it's better to use ament_export_dependencies for the image_transport rather than add the find_package(image_transport) in nav2_rviz_plugins.

Signed-off-by: Chen Lihui lihui.chen@sony.com

Signed-off-by: Chen Lihui <lihui.chen@sony.com>
rviz_default_plugins/CMakeLists.txt Outdated Show resolved Hide resolved
…cies sorted alphabetically

Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI.

@iuhilnehc-ynos
Copy link
Author

CI:
Build args: --packages-above-and-dependencies rviz_default_plugins
Test args: --packages-above rviz_default_plugins

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants