Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build for Ubuntu Jammy arm64. #828

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

clalancette
Copy link
Contributor

@clalancette clalancette commented Feb 8, 2022

It turns out that on newer glibc, the sys/sysctl.h header does
not exist. This caused the build to fail on Ubuntu Jammy.
There is an upstream one-line fix for this, so apply it here.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

Longer term (hopefully for Humble), we should try to switch to OGRE 1.12.7 or newer, at which point we can drop this patch.

It turns out that on newer glibc, the sys/sysctl.h header does
not exist.  This caused the build to fail on Ubuntu Jammy.
There is an upstream one-line fix for this, so apply it here.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Copy link
Contributor Author

clalancette commented Feb 8, 2022

CI:

  • Linux Focal Build Status
  • Linux-aarch64 Focal Build Status
  • Windows Build Status
  • Linux Jammy Build Status
  • Linux-aarch64 Jammy Build Status

Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clalancette clalancette merged commit 4e0086a into ros2 Feb 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the clalancette/fix-jammy-arm64 branch February 9, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants