Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use make_shared to construct PointCloud2 #869

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Use make_shared to construct PointCloud2 #869

merged 1 commit into from
Jun 21, 2022

Conversation

allenh1
Copy link
Contributor

@allenh1 allenh1 commented Jun 20, 2022

This is just a trivial change to use make_shared instead of the new operator for constructing a PointCloud2.

I also dropped the std::allocator<void> here, since it is not needed.

Signed-off-by: Hunter L. Allen hunter.allen@apex.ai

@allenh1
Use make_shared to construct PointCloud2
cfbaae8 
Signed-off-by: Hunter L. Allen <hunter.allen@apex.ai>
@allenh1 allenh1 added the in review Waiting for review (Kanban column) label Jun 20, 2022
@allenh1 allenh1 self-assigned this Jun 20, 2022
clalancette
clalancette approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, thanks for the fix.

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 057e227 into ros2 Jun 21, 2022
@clalancette clalancette deleted the use_make_shared_for_point_cloud_2 branch June 21, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees

@allenh1 allenh1

Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@allenh1 @clalancette