std::copy fix - OccupancyGridUpdate - Data is not being processed correctly #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue: #896 |
clalancette
requested changes
Sep 16, 2022
There was a problem hiding this comment.
@Eric-Bwr Thanks for the patch. I've left a requested change inline. Can you test that out and verify that it fixes the original issue for you?
rviz_default_plugins/src/rviz_default_plugins/displays/map/map_display.cpp
Outdated
Show resolved
Hide resolved
…_display.cpp Co-authored-by: Chris Lalancette <clalancette@gmail.com>
clalancette
approved these changes
Sep 19, 2022
|
CI:
|
|
The warning on Windows is unrelated to this PR (and has already been fixed elsewhere). So going ahead and merging this; thanks @Eric-Bwr ! |
|
No problem :) Thank you aswell! |
daisukes
pushed a commit
to CMU-cabot/rviz
that referenced
this pull request
May 3, 2023
…rectly (ros2#895) * std_copy_fix Co-authored-by: Eric Böwer <e.boewer@kalverkamp.de> Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the updating of the costmap. As described in the Issue.