use static QCoreApplication::processEvents() function without a QApplication instance #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what needs to happen, that this PR can be merged? |
clalancette
force-pushed
the
staticProcessEvents
branch
from
f30e59d
to
093ba87
Compare
clalancette
approved these changes
Jul 5, 2023
|
CI:
|
ahcorde
approved these changes
Jul 5, 2023
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
New CI after uncrustify fix:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need for the
setApp()call.As seen in the Qt documentation
processEventsis a static function so no member ofQCoreApplicationis required. Removing this takes away the need forsetApp()inVisualizationFrameandVisualizerAppwhich i have kept for now. I have encased thesetApplicationIcon()call with anifto protect against unwanted segfaults (There is no need to crash, just because the application icon could not be set).Why should the
VisualizationFrameset the application-icon in the first place?This seems a bit of. What if i have an app with 2 frames? Maybe an app with many other things and its own application-icon dont want the icon overwritten? But i guess that is a discussion, that should be held elsewhere.
Removing this requirement of having a
QApplication*help to ease integration rviz into other (possibly quite big) Qt-Applications.