Fix ODR errors with gmock #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: methylDragon <methylDragon@gmail.com>
31 tasks
|
mjcarroll
approved these changes
Apr 6, 2023
methylDragon
force-pushed
the
ch3/fix-odr
branch
7 times, most recently
from
2453634
to
84422aa
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
ch3/fix-odr
branch
from
84422aa
to
761307e
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
ch3/fix-odr
branch
from
e78516d
to
c6de021
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
|
wjwwood
approved these changes
Apr 8, 2023
There was a problem hiding this comment.
lgtm, it's a kind of ugly workaround, but after debugging this with @methylDragon I think this is the easiest way to satisfy Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test fixture is explicitly linking against gmock, but tests get linked again as a result of the ament_add_gmock call.
This causes an ODR violation, but it didn't seem to cause any issues with tests.
Running the QOS tests with asan causes ODR violations though.