Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cean Code #975

Merged
merged 3 commits into from
May 1, 2023
Merged

Cean Code #975

merged 3 commits into from
May 1, 2023

Conversation

mosfet80
Copy link
Contributor

remove unused old code

@mosfet80 mosfet80 requested a review from ahcorde as a code owner April 27, 2023 13:58
clalancette
clalancette approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, these look good to me! Thanks for the contribution.

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

clalancette
clalancette requested changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things to pass CI, then we can consider this one for rolling.

rviz_rendering/src/rviz_rendering/objects/shape.cpp Outdated Show resolved Hide resolved
rviz_rendering/src/rviz_rendering/render_window.cpp Outdated Show resolved Hide resolved
@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 82538e5 into ros2:rolling May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@ahcorde ahcorde Awaiting requested review from ahcorde ahcorde is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mosfet80 @clalancette