add libssl-dev as an exec dependency #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelarguedas
added
in progress
tfoote
previously requested changes
Jul 5, 2017
There was a problem hiding this comment.
If this is only runtime we should use the runtime package: https://github.com/ros/rosdistro/blob/master/rosdep/base.yaml#L3575
|
oh good point, I'll try it to make sure that works and update it + put that back in review when confirmed |
mikaelarguedas
added
in progress
|
Is this targeting the beta 2 release (which would require retagging / re-packaging)? |
|
nope this has been packages with a dependency on |
|
Ok this works fine with |
mikaelarguedas
added
in review
|
ready for 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
already in rosdep database here: https://github.com/ros/rosdistro/blob/master/rosdep/base.yaml#L2715