Add scope parameter to conftest.py #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
approved these changes
Jul 30, 2020
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
j-rivero
force-pushed
the
jrivero/mypy_regression
branch
from
b5ecb34
to
f4d58d8
Compare
sure, sorry for that. |
mikaelarguedas
approved these changes
Jul 30, 2020
There was a problem hiding this comment.
thanks @j-rivero !
lgtm,
Looks like DCO is failing, could you amend/sign your commit ? and it's already done !
That's how @j-rivero rolls. You think it and it happens! |
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
=======================================
Coverage 76.84% 76.84%
=======================================
Files 23 23
Lines 609 609
Branches 53 53
=======================================
Hits 468 468
Misses 121 121
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
j-rivero
added a commit
that referenced
this pull request
Jul 31, 2020
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following upstream instructions https://docs.pytest.org/en/stable/fixture.html#scope-sharing-fixtures-across-classes-modules-packages-or-session . Fix #229
Testing: