Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using new parameter API: allowing undeclared parameters. #356

Merged
merged 1 commit into from May 4, 2019
Merged

Using new parameter API: allowing undeclared parameters. #356

merged 1 commit into from May 4, 2019

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented May 3, 2019

Parameter API adaptation for ros2/rclpy#325.

Using new parameter API; allowing undeclared parameters.
36b3947 
Signed-off-by: Juan Ignacio Ubeira <jubeira@ekumenlabs.com>
@jubeira jubeira added the in progress Actively being worked on (Kanban column) label May 3, 2019
jacobperron
jacobperron approved these changes May 3, 2019
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with passing CI

@jubeira
Copy link
Contributor Author

jubeira commented May 4, 2019

CI:

  • Linux: Build Status
  • Linux-aarch64: Build Status
  • Mac OS: Build Status
  • Windows Build Status

Overall looks good; the failing cases seem to be unrelated.

@jubeira jubeira merged commit c548e3b into master May 4, 2019
@jubeira jubeira deleted the issue/#321_enhance_parameter_api branch May 4, 2019 00:52
@jubeira jubeira removed the in progress Actively being worked on (Kanban column) label May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jubeira @jacobperron