Use test fixtures to create SROS artifacts (backport #522) #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
|
The current implementation creates SROS artifacts during the configure phase. This is undesirable for a variety of reasons, such as: * The ros2 binary is invoked during build, meaning that a regression in that tool will break the entire CI build instead of appearing as a test failure. * Some of the environment is captured during the artifact generation and it may not be the same when the tests are invoked. Namely, changes to ROS_DOMAIN_ID between build and test will break. The test fixtures work similarly to tests themselves, and are automatically run if any tests requiring them are enabled. If the fixture fails, the dependent tests are not attempted. (cherry picked from commit d98fcb9) Signed-off-by: Scott K Logan <logans@cottsay.net>
All of these commands should be run together to set up the fixture for the tests. When running tests with repetition, we want to run through the entire artifact setup and not run each individual command multiple times. (cherry picked from commit af74e9f) Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
force-pushed
the
mergify/bp/humble/pr-522
branch
from
b170df8
to
fea2640
Compare
cottsay
added a commit
that referenced
this pull request
Aug 8, 2023
The current implementation creates SROS artifacts during the configure phase. This is undesirable for a variety of reasons, such as: * The ros2 binary is invoked during build, meaning that a regression in that tool will break the entire CI build instead of appearing as a test failure. * Some of the environment is captured during the artifact generation and it may not be the same when the tests are invoked. Namely, changes to ROS_DOMAIN_ID between build and test will break. The test fixtures work similarly to tests themselves, and are automatically run if any tests requiring them are enabled. If the fixture fails, the dependent tests are not attempted. (cherry picked from commit d98fcb9) Signed-off-by: Scott K Logan <logans@cottsay.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #522 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com