Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increased time in test_multithreaded #543

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Increased time in test_multithreaded #543

merged 1 commit into from
Apr 4, 2024

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Apr 4, 2024

In this nightly build I can see this error

12: /home/jenkins-agent/workspace/nightly_linux_coverage/ws/src/ros2/system_tests/test_rclcpp/test/test_multithreaded.cpp:421: Failure
12: Expected equality of these values:
12:   num_messages
12:     Which is: 40
12:   subscription_counter
12:     Which is: 32

Messages are there but not all of them, giving more time to complete the task.

@ahcorde
Increased time in test_multithreaded
e8dbfb8 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from clalancette April 4, 2024 15:45
@ahcorde ahcorde self-assigned this Apr 4, 2024
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 4, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 4, 2024

failures are unrelated, merging

@ahcorde ahcorde merged commit c90f086 into rolling Apr 4, 2024
2 of 3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/rolling/increase_time_test_multithreaded branch April 4, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@clalancette clalancette Awaiting requested review from clalancette

@methylDragon methylDragon Awaiting requested review from methylDragon methylDragon is a code owner

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahcorde @fujitatomoya