remove blocks and workarounds on service tests #162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might be ready to be removed as well, right? (couldn't add a line comment) |
|
Yeah, but it would need to be replaced with a |
|
is this |
|
Ah, yeah it is. Sorry, should have read more of the context. |
|
Removed it in 2bc1097. |
|
I'm going to close this pr and push the changes to a different branch name, that way I can test the other changes on this branch name without these because they break Connext. |
|
New branch name is |
This was referenced Sep 20, 2016
wjwwood
pushed a commit
that referenced
this pull request
Sep 21, 2016
* Add regression test for different behaviour between first and second client (#156) * Add regression test for different behaviour between first and second client * lint * Fix compiler warnings * Spelling fixup * remove blocks and workarounds on new service test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not be merged with ros2/rmw_fastrtps#56, but can be used for testing it, if Connext is not tested at the same time.
This can be merged once Connext has been updated to support wait_for_service complete as well (in progress).
Connects to ros2/rmw_fastrtps#56