Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression test for recursive service calls #254

Merged
merged 1 commit into from
Dec 4, 2017
Merged

Add regression test for recursive service calls #254

merged 1 commit into from
Dec 4, 2017

Conversation

dhood
Copy link
Member

@dhood dhood commented Dec 3, 2017

Connects to ros2/rclcpp#415

Without ros2/rclcpp#415 the client can't send the second service call because it deadlocks trying to lock the internal mutex.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@dhood dhood added the in review Waiting for review (Kanban column) label Dec 3, 2017
@dhood dhood self-assigned this Dec 3, 2017
@dhood dhood mentioned this pull request Dec 3, 2017
Merged
@dhood dhood merged commit d0b1e6d into master Dec 4, 2017
@dhood dhood deleted the recursive_client_call branch December 4, 2017 01:12
@dhood dhood removed the in review Waiting for review (Kanban column) label Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees

@dhood dhood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhood @wjwwood