adding a test and a commented out test for the bind that doesn't compile #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@esteve For full testing of ros2/rclcpp#183 you'll need to uncomment the second added test block in this branch. |
|
I got this to compile fine together with ros2/rclcpp#183, at least locally on Linux |
|
I've merged ros2/rclcpp#183, so if you uncomment the test here, I think the CI jobs will pass. |
|
I'm testing it locally against your branch. If it passes I'll update the PR |
tfoote
force-pushed
the
method_based_callback
branch
from
8d8a2cb
to
7547dee
Compare
|
+1 |
tfoote
force-pushed
the
method_based_callback
branch
from
7547dee
to
c20352f
Compare
tfoote
force-pushed
the
method_based_callback
branch
2 times, most recently
from
0c85fbe
to
41964e7
Compare
tfoote
force-pushed
the
method_based_callback
branch
from
4439e4b
to
ce6dc44
Compare
|
@tfoote I've added support for plain functions and |
|
Thanks @esteve it's not necessary for my use case but I suspect that it will be useful to others. |
tfoote
added a commit
that referenced
this pull request
Dec 16, 2015
adding a test and a commented out test for the bind that doesn't compile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rclcpp#173